Il 06/03/2013 22:19, Marcelo Tosatti ha scritto: > Vcpu should only invoke kvm_emulate_halt if it has been through a > KVM_MP_STATE_UNINITIALIZED -> KVM_MP_STATE_INIT_RECEIVED -> > KVM_MP_STATE_SIPI_RECEIVED -> KVM_MP_STATE_RUNNABLE transition. > > If it has been through that, how can a KVM_MP_STATE_INIT_RECEIVED be > overwritten? > > That is, KVM_MP_STATE_RUNNABLE (precondition for kvm_emulate_halt) is > only reachable if KVM_MP_STATE_INIT_RECEIVED/KVM_MP_STATE_SIPI_RECEIVED > have not been overwritten. You can always go back to the KVM_MP_STATE_INIT_RECEIVED state; either by an APIC write or by various soft resets (port 92h, keyboard controller, port cf9h) that aren't emulated correctly right now. Paolo > The point i'm trying to make is it appears the symptom is being fixed > with the proposed patch, not the root cause (which, if the reasoning > above is correct, is somewhere in nVMX code). -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html