On Wed, Mar 06, 2013 at 12:58:39PM +0100, Alexander Graf wrote: > > On 06.03.2013, at 12:57, Paolo Bonzini wrote: > > >>> I agree. But is the device really being created at CREATE_DEVICE > >>> time? What happens if you create N CPUs and N-1 irqchips? > >> > >> irqchip in CREATE_DEVICE is the IOAPIC, not the LAPIC. The LAPIC gets > >> spawned at vcpu creation. > >> > >>> On x86, the LAPIC is created magically together with the VCPU. > >> > >> Yes, and so far I haven't seen any proposal to change this even in > >> the CREATE_DEVICE world. > > > > But don't you need anyway an id to get/set the device properties of > > the per-VCPU irqchip? If you were adding the x86 irqchip with the > > new API, what would be the replacement of KVM_GET_LAPIC/KVM_SET_LAPIC? > > In the current model, that would be ONE_REG registers on the vcpus. > Yes, the same way as KVM_GET_LAPIC is per cpu ioctl. No need for special ID. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
