Hello, Am 02.03.2013 16:18, schrieb Sanjay Lal: > The following patchset implements KVM support for MIPS32 processors, > using Trap & Emulate, with basic runtime binary translation to improve > performance. [snip] Please see http://wiki.qemu.org/Contribute/SubmitAPatch for some hints on how to improve submission of your QEMU patchset. In particular we require Signed-off-bys just like Linux, subjects should use "target-mips: " or similar based on file/directory names, subject line should be one short statement and commit message should give further explanations of what the patch is doing and why, where appropriate. Also a fair warning: I am refactoring the core CPU code, so you should be tracking qemu.git and/or mailing list for possible conflicts and rebasing necessary. In that context please prefer use of MIPSCPU over CPUMIPSState (e.g., in GIC state and functions). Please adopt our Coding Style, which among other things asks for CamelCase struct naming (e.g., MIPSGICState rather than gic_t). Please learn about QOM usage and its conventions. Your GIC should probably be a SysBusDevice, not a pre-qdev collection of manually allocated state. http://wiki.qemu.org/QOMConventions There's also an ongoing discussion about DPRINTF()s defined as no-op "do {} while(0)" leading to format string breakages over time. Recommended replacement is a macro using "do { if (FOO) { ... } } while (0)", with FOO evaluating to 0 in the no-debug case, so that everything gets compile-tested but optimized out. Regards, Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
