On 4 March 2013 19:10, Andreas Färber <afaerber@xxxxxxx> wrote: > Am 26.02.2013 18:40, schrieb Peter Maydell: >> if (s->num_cpu > NCPU) { >> - hw_error("requested %u CPUs exceeds GIC maximum %d\n", >> - s->num_cpu, NCPU); >> + error_setg(errp, "requested %u CPUs exceeds GIC maximum %d\n", > > Please drop \n for error_setg(). Probably would be worth adding to a > convert-to-realize section on the Wiki. Doh. That's such a trivial change I intend to just make it in passing when I put these changes into target-arm.next rather than sending out an entire fresh round of patches, unless you object. > Otherwise looks fine, thanks. Should I mark such a fixed-up patch with your reviewed-by tag? thanks -- PMM -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html