On Wed, Feb 20, 2013 at 04:13:49PM +0800, Hu Tao wrote: > On Thu, Feb 07, 2013 at 11:50:28PM -0200, Marcelo Tosatti wrote: > > On Wed, Jan 23, 2013 at 03:19:23PM +0800, Hu Tao wrote: > > > From: Wen Congyang <wency@xxxxxxxxxxxxxx> > > > > > > The guest should run after resetting it, but it does not run if its > > > old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. > > > > > > We don't set runstate to RUN_STATE_PAUSED when resetting the guest, > > > so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or > > > RUN_STATE_PAUSED to RUN_STATE_RUNNING(not RUN_STATE_PAUSED). > > > > It appears the last hunk will automatically reset state from > > RUN_STATE_INTERNAL_ERROR to RUN_STATE_RUNNING ? > > Yes. > > > > > I suppose the transition table allows, from RUN_STATE_INTERNAL_ERROR: > > > > <monitor> system_reset > > <monitor> cont > > > > To resume the machine? > > True. > > I think the purpose of this patch is to always reset and _run_ the guest > by `system_reset', avoiding an additional `cont' following `system_reset'. Unclear why its essential to the feature being proposed? -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html