Re: [PATCH 2/7] Added ONE_REG interface for debug instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28.02.2013, at 17:23, Scott Wood wrote:

> On 02/27/2013 10:13:11 PM, Bharat Bhushan wrote:
>> diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c
>> index 8b553c0..a41cd6d 100644
>> --- a/arch/powerpc/kvm/booke.c
>> +++ b/arch/powerpc/kvm/booke.c
>> @@ -1448,6 +1448,12 @@ int kvm_vcpu_ioctl_get_one_reg(struct kvm_vcpu *vcpu, struct kvm_one_reg *reg)
>> 	case KVM_REG_PPC_TSR:
>> 		r = put_user(vcpu->arch.tsr, (u32 __user *)(long)reg->addr);
>> 		break;
>> +	case KVM_REG_PPC_DEBUG_INST: {
>> +		u32 opcode = KVMPPC_INST_EHPRIV;
>> +		r = copy_to_user((u32 __user *)(long)reg->addr,
>> +				 &opcode, sizeof(u32));
>> +		break;
>> +	}
> 
> We're using ehpriv even for PR-mode KVM (e.g. e500v2)?

If it's a reserved instruction, that should work. Since we need to use a single instruction to replace the debugged one with, any reserved opcode should be as good as any other, right?


Alex

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux