On 25.02.2013, at 14:14, Andreas Färber wrote:
> Am 25.02.2013 13:54, schrieb Alexander Graf:
>>
>> On 21.02.2013, at 05:25, Andreas Färber wrote:
>>
>>> Make debug output compile-testable even if disabled.
>>>
>>> Rename dprintf() in kvm.c to kvm_dprintf() to avoid conflict with glibc.
>>>
>>> Inline DEBUG_OP check in excp_helper.c.
>>> Inline LOG_MMU_STATE() in mmu_helper.c.
>>> Inline PPC_{DEBUG_SPR,DUMP_SPR_ACCESSES} checks in translate_init.c.
>>>
>>> Signed-off-by: Andreas Färber <afaerber@xxxxxxx>
>>
>> I assume you verified that all the bits do get optimized out, right? :)
>
> No, I didn't for each, my focus was to make debug code compile and keep
> it compiling after my CPU changes. :)
>
> Please read up on the new discussion of rth not liking static const and
> proposing to go back to v1, modulo do { ... } while (0).
>
> Like I said there, if finding a solution that pleases everyone fails,
> then I will leave it to the maintainers (i.e., you) to choose and apply
> a solution or to live with the resulting breakages.
I care about 2 things:
* #ifdef works
* if not defined then the code should get optimized out
:). Everything else is icing on top.
Alex
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
