On Sat, Feb 23, 2013 at 09:42:14PM +0200, Gleb Natapov wrote: > > explanation why its believed to be benign (given how the injection > > return value is interpreted) could also work. Its ugly, though... murphy > > is around. > The race above is not benign. It will report interrupt as coalesced > while in reality it is injected. This may cause to many interrupt to be > injected. If this happens rare enough ntp may be able to fix time drift > resulted from this. OK. > > OTOH spinlock is not the end of the world, can figure out something later > > (we've tried without success so far). > It serializes all injections into vcpu. I do not believe now that even > with lock we are safe for the reason I mention above. We can use pir->on > bit as a lock, but that only emphasise how ridiculous serialization of > injections becomes. Please review the 2nd iteration of pseudocode in patchset v4 thread, it should be good. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
