Il 17/02/2013 07:37, Asias He ha scritto:
>> > static int __virtblk_add_req(struct virtqueue *vq,
>> > - struct virtblk_req *vbr)
>> > + struct virtblk_req *vbr,
>> > + struct scatterlist *data_sg,
>> > + unsigned data_nents)
>> > {
>> > struct scatterlist sg;
>> > enum dma_data_direction dir;
>> > int ret;
>> >
>> > + int type = vbr->out_hdr.type & ~VIRTIO_BLK_T_OUT;
>> > unsigned int nents = 2;
>> > unsigned int nsg = 2;
>> >
>> > - if (vbr->nents) {
>> > + if (type == VIRTIO_BLK_T_SCSI_CMD) {
>> > + BUG_ON(use_bio);
> Do we really need the BUG_ON? Even if with use_bio=1,
> VIRTIO_BLK_T_SCSI_CMD cmd can be fired. See this:
I stand corrected... will send the patch with this removed.
Paolo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
