On 2013-02-16 15:46, Nadav Har'El wrote: > On Sat, Feb 16, 2013, Jan Kiszka wrote about "Re: [PATCH] KVM: nVMX: Fix injection of PENDING_INTERRUPT and NMI_WINDOW exits to L1": >> No, this is wrong. I first wrote a patch that ignored enable_irq_window >> when the guest is not interested in external IRQs. But then I thought >> that wasn't correct. I tend to believe now my first idea was better. > > If you want to make the !PIN_BASED_EXT_INTR_MASK case work correctly, > please also see: > > https://bugzilla.kernel.org/show_bug.cgi?id=53711 Yes, I already realized that there is more broken. Trying to find a way to fix this ATM. That specifically means deciding when to execute vmx_complete/cancel_interrupts and when not. This patch seems correct now, just insufficient to make direct injection from L0 to L2 work. Jan
Attachment:
signature.asc
Description: OpenPGP digital signature
