Re: [PATCH 4/8] Added ONE_REG interface for debug instruction

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 07, 2013 at 03:29:50PM +0100, Alexander Graf wrote:
> 
> On 04.02.2013, at 01:41, Paul Mackerras wrote:
> 
> > On Wed, Jan 16, 2013 at 01:54:41PM +0530, Bharat Bhushan wrote:
> >> This patch adds the one_reg interface to get the special instruction
> >> to be used for setting software breakpoint from userspace.
> > 
> > Since this presumably is constant for any given platform, wouldn't
> > a capability be more appropriate?
> 
> How so? A capability only tells you "I can do debug". Or "I can do debug on e500". I don't want to reteach QEMU how to do debug for every core we implement.

Capabilities aren't just binary - the get-capability (check_extension)
ioctl returns a 32-bit value, and we already have some that return
values other than 0 or 1.  So I was thinking that we could add a
capability which when queried returns the special instruction.  It's
up to you whether you want to do it that way or not.

Paul.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux