On Mon, 28 Jan 2013 08:36:56 -0700 Alex Williamson <alex.williamson@xxxxxxxxxx> wrote: > On Mon, 2013-01-28 at 21:25 +0900, Takuya Yoshikawa wrote: > > On Mon, 28 Jan 2013 12:59:03 +0200 > > Gleb Natapov <gleb@xxxxxxxxxx> wrote: > > > > > > It sets spte based on the old value that means the readonly flag check > > > > is missed. We need to call kvm_arch_flush_shadow_all under this case. > > > Why not just disallow changing memory region KVM_MEM_READONLY flag > > > without deleting the region? > > > > Sounds good. > > > > If you prefer, I can fold the required change into my patch. > > That would seem to make my patch 1/2 unnecessary. Thanks, I've decided not to fold that change into my KVM: set_memory_region: Identify the requested change explicitly since this is a functional change, see v3 I posted today. Since QEMU is not the only hypervisor using KVM, we should make the change with a proper subject informing every user of the new restriction. If the maintainers prefer to remove Alex's patch 1/2 first and then rebase my v3 patch, I can do so. Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
