Hi, Thank you for submitting your patch series. checkpatch.pl has detected that one or more of the patches in this series violate the QEMU coding style. If you believe this message was sent in error, please ignore it or respond here with an explanation. Otherwise, please correct the coding style issues and resubmit a new version of the patch. For more information about QEMU coding style, see: http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD Here is the output from checkpatch.pl: Subject: s390: Add s390-ccw-virtio machine. Subject: s390: Add default support for SCLP console ERROR: do not initialise statics to 0 or NULL #72: FILE: vl.c:2468: + static int index = 0; WARNING: braces {} are necessary for all arms of this statement #126: FILE: vl.c:3923: + if (default_sclp) [...] WARNING: braces {} are necessary for all arms of this statement #135: FILE: vl.c:3937: + if (default_sclp) [...] WARNING: braces {} are necessary for all arms of this statement #144: FILE: vl.c:4109: + if (foreach_device_config(DEV_SCLP, sclp_parse) < 0) [...] total: 1 errors, 3 warnings, 114 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Subject: s390-virtio: Factor out some initialization code. Subject: s390: Add new channel I/O based virtio transport. Subject: s390: Wire up channel I/O in kvm. Subject: s390: Virtual channel subsystem support. ERROR: need consistent spacing around '*' (ctx:WxV) #56: FILE: hw/s390x/css.c:31: + SubchDev *sch[MAX_SCHID + 1]; ^ ERROR: need consistent spacing around '*' (ctx:WxV) #62: FILE: hw/s390x/css.c:37: + SubchSet *sch_set[MAX_SSID + 1]; ^ ERROR: need consistent spacing around '*' (ctx:WxV) #74: FILE: hw/s390x/css.c:49: + CssImage *css[MAX_CSSID + 1]; ^ total: 3 errors, 0 warnings, 1469 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Subject: s390: Add channel I/O instructions. Subject: s390: I/O interrupt and machine check injection. Subject: s390: Channel I/O basic definitions. Subject: s390: Add mapping helper functions. Subject: s390: Lowcore mapping helper. Regards, Anthony Liguori -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
