> -----Original Message----- > From: Wood Scott-B07421 > Sent: Thursday, January 24, 2013 12:22 PM > To: Yoder Stuart-B08248 > Cc: agraf@xxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; linuxppc-dev@xxxxxxxxxx; kvm-ppc@xxxxxxxxxxxxxxx; > kvm@xxxxxxxxxxxxxxx; Yoder Stuart-B08248 > Subject: Re: [PATCH][v2] KVM: PPC: add paravirt idle loop for 64-bit book E > > On 01/22/2013 05:54:43 PM, Stuart Yoder wrote: > > +.macro BOOK3E_IDLE_LOOP > > +1: > > + PPC_WAIT(0) > > b 1b > > +.endm > > + > > +.macro EPAPR_EV_IDLE_LOOP > > +idle_loop: > > + LOAD_REG_IMMEDIATE(r11, EV_HCALL_TOKEN(EV_IDLE)) > > + > > +.global epapr_ev_idle_start > > +epapr_ev_idle_start: > > + li r3, -1 > > + nop > > + nop > > + nop > > + b idle_loop > > +.endm > > + > > +BOOK3E_IDLE epapr_ev_idle, EPAPR_EV_IDLE_LOOP > > + > > +BOOK3E_IDLE book3e_idle BOOK3E_IDLE_LOOP > > Why the comma after epapr_ev_idle but not after book3e_idle? > > Also you have spaces where there should be tabs. > > Otherwise looks good. Hmm...there shouldn't be a comma there. I'll respin and fix the whitespace too. Stuart -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
