On Jan 24, 2013, at 10:05 AM, Ralf Baechle wrote: > On Wed, Nov 21, 2012 at 06:33:58PM -0800, Sanjay Lal wrote: > > I've queued the patch set. I've done a few stylistic changes such as > getting rid of all use of ulong and u_long data types in favor of > unsigned long. I also ran into the following modpost error > > ERROR: "kvm_arch_vcpu_postcreate" [arch/mips/kvm/kvm.ko] undefined! > > which I fixed by adding a trivial kvm_arch_vcpu_postcreate function: > > intkvm_arch_vcpu_postcreate((struct kvm_vcpu *vcpu) > { > return 0; > } > > which may or may not be sufficient. > > Enabling CONFIG_KVM_MIPS_VZ was causing build errors. Since the support > code for the VZ ASE is not part of this series, I've ripped that out > entirely. > > As for the __unused references, some are indeed unused with no apparent > reason for why the variables shouldn't be removed. There are also > variables marked __unused which are being used - so no point in marking > them. I've sorted that, too. > > Ralf Thanks Ralf. the kvm_arch_vcpu_postcreate() fix is fine, as are the others. Regards Sanjay -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html