On Wed, Jan 16, 2013 at 05:57:34PM +0000, Christoffer Dall wrote: > --- a/arch/arm/mm/idmap.c > +++ b/arch/arm/mm/idmap.c > @@ -1,4 +1,6 @@ > +#include <linux/module.h> Minor thing - do you need to include linux/module.h here? > + identity_mapping_add(hyp_pgd, __hyp_idmap_text_start, > + __hyp_idmap_text_end, PMD_SECT_AP1); It would be more consistent if you define PMD_SECT_HYP or something like that. I think you have a L_PTE_HYP bit as well. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html