On Wed, 23 Jan 2013 21:45:23 +0800 Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx> wrote: > > The current code which deletes the two link nodes in different functions > > looks unnatural to me: traversing the sp->link nodes forces us to break > > the loop and sp->hash_link nodes alone is allowed to continue ... > > > > Making each function semantically clear should be more important than > > other things. > > > > The reason the code like this is, we have lockless shadow page walker. But hash_link needs to be protected by mmu_lock anyway? > > But maybe a matter of taste, so I'll wait for the maintainers' comments. > > > >> http://www.linux-kvm.org/page/TODO: O(1) mmu invalidation using a generation number > >> > >> I am doing this work for some weeks and will post the patch out during these days. > > > > I remember that Avi originally wrote the idea of introducing the > > generation of mmu pages in his other work. > > > > Whatever the original consideration is, the idea can speed up mmu invalidation a lot. > (Actually, i mentioned this idea to you when discussion fast write protect long time ago.) It's fine. I just wanted to know if my memory was correct. Takuya -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
