On Mon, Jan 21, 2013 at 08:16:18PM -0200, Marcelo Tosatti wrote:
> On Mon, Jan 21, 2013 at 11:34:20PM +0200, Gleb Natapov wrote:
> > On Mon, Jan 21, 2013 at 07:21:13PM -0200, Marcelo Tosatti wrote:
> > > On Mon, Jan 21, 2013 at 10:21:14PM +0200, Gleb Natapov wrote:
> > > > > > }
> > > > > > +
> > > > > > + vcpu->arch.apic_base = value;
> > > > >
> > > > > Simpler to have
> > > > >
> > > > > if (apic_x2apic_mode(apic)) {
> > > > > ...
> > > > > kvm_x86_ops->set_virtual_x2apic_mode(vcpu, true);
> > > > > } else {
> > > > > kvm_x86_ops->set_virtual_x2apic_mode(vcpu, false);
> > > > > }
> > > > >
> > > > This will not work during cpu init. That was discussed on one of
> > > > the previous iterations of the patch. When this code is called during
> > > > vcpu init vmcs is not loaded yet so set_virtual_x2apic_mode() cannot
> > > > write into it.
> > >
> > > Are you saying that the logic to write on bit value change is due to
> > > ordering with cpu init or that the callback is at the wrong place?
> > >
> > The logic is because of ordering with cpu init.
>
> OK. Still must move this conditional callback after assignment of apic_base.
>
Sure.
--
Gleb.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
