RE: [PATCH v11 3/3] x86, apicv: add virtual interrupt delivery support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Marcelo Tosatti wrote on 2013-01-22:
> On Mon, Jan 21, 2013 at 11:18:28PM +0200, Gleb Natapov wrote:
>> On Mon, Jan 21, 2013 at 07:05:43PM -0200, Marcelo Tosatti wrote:
>>>> +	struct vcpu_vmx *vmx = to_vmx(vcpu);
>>>> +
>>>> +	if (WARN_ONCE((vector > 255),
>>>> +		"KVM VMX: vector (%d) out of range\n", vector))
>>>> +		return;
>>> 
>>> Please remove the WARN_ON, inject triple fault if this happens
>>> (and add a tracepoint).
>>> 
>> Since this cannot be triggered by a guest triple fault is unwarranted.
>> Vector can be greater than 255 here only due to KVM bug, so WARN() or
>> even BUG() is appropriate.
> 
> Then BUG_ON().
Sure. 

Best regards,
Yang


--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux