On Fri, Jan 18, 2013 at 01:48:38PM +0200, Gleb Natapov wrote: > On Fri, Jan 18, 2013 at 09:36:33AM -0200, Eduardo Habkost wrote: > > On Fri, Jan 18, 2013 at 12:17:56PM +0100, Andreas Färber wrote: > > > Am 17.01.2013 21:59, schrieb Eduardo Habkost: > > > > Signed-off-by: Eduardo Habkost <ehabkost@xxxxxxxxxx> > > > > --- > > > > Cc: kvm@xxxxxxxxxxxxxxx > > > > Cc: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > Cc: Gleb Natapov <gleb@xxxxxxxxxx> > > > > Cc: Marcelo Tosatti <mtosatti@xxxxxxxxxx> > > > > > > It appears as if Cc: below --- gets ignored? Please check and ping those > > > people if necessary. > > > > I believe it depends on git-send-email suppress-cc option. At least I > > remember this format have worked for me before, I need to check what > > changed on my config. > > > > > > > > Personally, I adopted the convention of having to-be-persisted CCs above > > > Sob and stripping trailing CCs when applying. > > > > I considered the CC lines not part of the commit message (just like the > > changelog isn't), so I decided to put them after "---". > > > This may be the reason git-send-email ignored it. I just tested it here, and it ignored it because I have suppress-cc=all enabled by default and (by mistake) I didn't use my script that explicitly disabled it. If I use --suppress-cc=author, git-send-email uses the CC lines before _and_ after "---". -- Eduardo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
