On Wed, Jan 16, 2013 at 11:17:06AM -0500, Christoffer Dall wrote: > On Wed, Jan 16, 2013 at 10:52 AM, Gleb Natapov <gleb@xxxxxxxxxx> wrote: > > On Wed, Jan 16, 2013 at 10:42:02AM -0500, Christoffer Dall wrote: > >> [...] > >> > >> > > >> >> read side RCU protects against is the memslots data structure as far > >> >> as I can see, so the second patch pasted below fixes this for the code > >> >> that actually accesses this data structure. > >> > Many memory related functions that you call access memslots under the > >> > hood and assume that locking is done by the caller. From the quick look > >> > I found those that you've missed: > >> > kvm_is_visible_gfn() > >> > kvm_read_guest() > >> > gfn_to_hva() > >> > gfn_to_pfn_prot() > >> > kvm_memslots() > >> > > >> > May be there are more. Can you enable RCU debugging in your kernel config > >> > and check? This does not guaranty that it will catch all of the places, > >> > but better than nothing. > >> > > >> > >> yeah, I missed the call to is_visible_gfn and friends, this fixes it: > >> > > Thank you. One more kvm_read_guest() in emulate.c. > > > > this one is going out for now (see the i/o discussion). > I thought there wasn't resolution yet. Guess I missed something. If kvm_read_guest() is removed from emulator then the patch looks good to me. -- Gleb. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
