Re: [RFC/PATCH 1/1] s390/kvm: Fix BUG in include/linux/kvm_host.h:745

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 08, 2013 at 04:23:10PM +0100, Christian Borntraeger wrote:
> commit b080935c8638e08134629d0a9ebdf35669bec14d
>     kvm: Directly account vtime to system on guest switch
> 
> also removed the irq_disable/enable around kvm guest switch, which
> is correct in itself. Unfortunately, there is a BUG ON that (correctly)
> checks for preemptible to cover the call to rcu later on.
> (Introduced with commit 8fa2206821953a50a3a02ea33fcfb3ced2fd9997
>     KVM: make guest mode entry to be rcu quiescent state)
> 
> This check might trigger depending on the kernel config.
> Lets make sure that no preemption happens during kvm_guest_enter.
> We can enable preemption again after the call to
> rcu_virt_note_context_switch returns.
> 
> Please note that we continue to run s390 guests with interrupts
> enabled.
> 
> CC: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> CC: Gleb Natapov <gleb@xxxxxxxxxx>
> Signed-off-by: Christian Borntraeger <borntraeger@xxxxxxxxxx>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux