Re: [kvmarm] [PATCH v5.1 0/2] KVM: ARM: Rename KVM_SET_DEVICE_ADDRESS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/09/2013 10:48:47 AM, Alexander Graf wrote:

On 09.01.2013, at 17:26, Christoffer Dall wrote:

> Renames the KVM_SET_DEVICE_ADDRESS to KVM_ARM_SET_DEVICE_ADDR
> to make it obvious that this is ARM specific in lack of a better generic
> interface.
>
> Once we agree on a better interface the KVM/ARM code can also take
> advantage of that, but until then we don't want to hold up the KVM/ARM
> patches.

Works for me. Scott, are you happy with this one too?

Not really, given that it will stay around forever even after something new is introduced.

If you're going to change the name, why not just change it to KVM_SET_DEVICE_CONFIG? Can we change the name later if nothing else changes (so it's still binary compatible)?

We can start to introduce (and fix ARM) with a generic ioctl in the MPIC patches then.

The ioctl is already generic, except for its name.

-Scott
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux