On 01/09/2013 05:56 PM, Stefan Hajnoczi wrote: > On Fri, Dec 28, 2012 at 06:31:53PM +0800, Jason Wang wrote: >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 5dfa052..583eb7c 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -2465,7 +2465,7 @@ >> { 'type': 'NetdevTapOptions', >> 'data': { >> '*ifname': 'str', >> - '*fd': 'str', >> + '*fd': ['String'], > This change is not backwards-compatible. You need to add a '*fds': > ['String'] field instead. I'm not quite understand this case, I think it still work when we we just specify one fd. >> '*script': 'str', >> '*downscript': 'str', >> '*helper': 'str', >> @@ -2473,7 +2473,8 @@ >> '*vnet_hdr': 'bool', >> '*vhost': 'bool', >> '*vhostfd': 'str', >> - '*vhostforce': 'bool' } } >> + '*vhostforce': 'bool', >> + '*queues': 'uint32'} } > The 'queues' parameter should not be necessary when fd passing is used > since we can learn the number of queues by looking at the list length. Ok. > > Stefan -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html