On Thu, 20 Dec 2012, Sasha Levin wrote: > We already know q!=NULL at that point, no need to retest. > Right, and even if it was ==NULL then 'free(NULL)' is guaranteed to be a NOP, so it would still be fine. Reviewed-by: Jesper Juhl <jj@xxxxxxxxxxxxx> > Signed-off-by: Sasha Levin <sasha.levin@xxxxxxxxxx> > --- > tools/kvm/disk/qcow.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/tools/kvm/disk/qcow.c b/tools/kvm/disk/qcow.c > index ee2992e..64a2550 100644 > --- a/tools/kvm/disk/qcow.c > +++ b/tools/kvm/disk/qcow.c > @@ -1361,8 +1361,7 @@ free_header: > if (q->header) > free(q->header); > free_qcow: > - if (q) > - free(q); > + free(q); > > return NULL; > } > @@ -1492,8 +1491,7 @@ free_header: > if (q->header) > free(q->header); > free_qcow: > - if (q) > - free(q); > + free(q); > > return NULL; > } > -- Jesper Juhl <jj@xxxxxxxxxxxxx> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
