Re: [PATCH v2] kvm-tool: ARM: set interrupt priority mask in secondary boot path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 30, 2012 at 02:51:28PM +0000, Marc Zyngier wrote:
> A bug in the KVM GIC init code set the priority mask to the
> highest possible value, while the reset value should be zero.
> 
> Now that the kernel bug is fixed, kvm-tool must properly configure
> its GIC CPU interface in order to receive the boot IPI.  Just set
> the GICC_PMR register to the maximum value (0xff), and it "just works".
> 
> Cc: Will Deacon <will.deacon@xxxxxxx>
> Cc: Pekka Enberg <penberg@xxxxxxxxxx>
> Signed-off-by: Marc Zyngier <marc.zyngier@xxxxxxx>
> ---
> v2: Changed the constant name to GIC_CPUI_PMR_MIN_PRIO, as suggested by
>     Peter Maydell
> 
>  tools/kvm/arm/aarch32/smp-pen.S        | 4 ++++
>  tools/kvm/arm/include/arm-common/gic.h | 2 ++
>  2 files changed, 6 insertions(+)
> 
> diff --git a/tools/kvm/arm/aarch32/smp-pen.S b/tools/kvm/arm/aarch32/smp-pen.S
> index 0861171..2398297 100644
> --- a/tools/kvm/arm/aarch32/smp-pen.S
> +++ b/tools/kvm/arm/aarch32/smp-pen.S
> @@ -17,6 +17,10 @@ smp_pen_start:
>  	mov	r1, #GIC_CPUI_CTLR_EN
>  	str	r1, [r0]
>  
> +	@ Set the priority mask to accept any interrupt
> +	mov	r1, #GIC_CPUI_PMR_MIN_PRIO
> +	str	r1, [r0, #4]

nit: can you #define the register offset in arm-common/gic.h please?

Will
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux