On 11/20/2012 12:15 PM, Will Deacon wrote:
> Hi Sasha,
>
> On Tue, Nov 13, 2012 at 04:37:38AM +0000, Sasha Levin wrote:
>> On 11/12/2012 06:57 AM, Will Deacon wrote:
>>> struct kvm {
>>> struct kvm_arch arch;
>>> struct kvm_config cfg;
>>> @@ -49,6 +56,7 @@ struct kvm {
>>> u64 ram_size;
>>> void *ram_start;
>>> u64 ram_pagesize;
>>> + struct list_head mem_banks;
>>
>> These memory banks actually look like a perfect example to use our augmented interval rb-tree,
>> can we switch them to use it, or is it a list on purpose?
>
> I found some time to look at this today but unfortunately they're not as
> ideally suited to the interval tree as they look: the problem being that we
> need to search for banks by both host virtual address *and* guest physical
> address depending on the translation that we're doing.
>
> We could have two separate tress, but that seems like overkill given the
> likely number of banks.
Makes sense. We can convert it later if we need to as well.
Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
