On 10/30/2012 02:33 AM, Isaku Yamahata wrote:
> This is for benchmark purpose
>
> Signed-off-by: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
> +++ b/qapi-schema.json
> @@ -2095,7 +2095,7 @@
> ##
> { 'command': 'migrate',
> 'data': {'uri': 'str', '*blk': 'bool', '*inc': 'bool', '*detach': 'bool' ,
> - '*postcopy': 'bool'} }
> + '*postcopy': 'bool', '*nobg': 'bool'} }
Again, document this option above, and mention that it was introduced in
1.3. In QMP, we prefer easier-to-read strings, I would consider naming
it 'background' with a default of true, where you pass false to get the
new behavior, instead of 'nobg' with a default of false and causing
double-negative logic.
--
Eric Blake eblake@xxxxxxxxxx +1-919-301-3266
Libvirt virtualization library http://libvirt.org
Attachment:
signature.asc
Description: OpenPGP digital signature
