Re: [patch 08/18] x86: pvclock: generic pvclock vsyscall initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/29/2012 07:54 AM, Marcelo Tosatti wrote:
> On Mon, Oct 29, 2012 at 06:18:20PM +0400, Glauber Costa wrote:
>> On 10/24/2012 05:13 PM, Marcelo Tosatti wrote:
>>> Index: vsyscall/arch/x86/Kconfig
>>> ===================================================================
>>> --- vsyscall.orig/arch/x86/Kconfig
>>> +++ vsyscall/arch/x86/Kconfig
>>> @@ -632,6 +632,13 @@ config PARAVIRT_SPINLOCKS
>>>  
>>>  config PARAVIRT_CLOCK
>>>  	bool
>>> +config PARAVIRT_CLOCK_VSYSCALL
>>> +	bool "Paravirt clock vsyscall support"
>>> +	depends on PARAVIRT_CLOCK && GENERIC_TIME_VSYSCALL
>>> +	---help---
>>> +	  Enable performance critical clock related system calls to
>>> +	  be executed in userspace, provided that the hypervisor
>>> +	  supports it.
>>>  
>>>  endif
>> Besides debugging, what is the point in having this as an
>> extra-selectable? Is there any case in which a virtual machine has code
>> for this, but may decide to run without it ?
> Don't think so (its pretty small anyway, the code).
>
>> I believe all this code in vsyscall should be wrapped in PARAVIRT_CLOCK
>> only.
> Unless Jeremy has a reason, i'm fine with that.

I often set up blind config variables for dependency management; I'm
guessing the "GENERIC_TIME_VSYSCALL" dependency is important.  I think
the problem is that this exists, but that it's a user-selectable
option.  Removing the prompt should fix that.

    J

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux