Re: [PATCH 2/5] kvm tools: use the correct config vector interrupt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2012 at 3:03 AM, Pekka Enberg <penberg@xxxxxxxxxx> wrote:
> On Wed, 24 Oct 2012, William Dauchy wrote:
>> when registering the config interrupt, the later is registered in
>> vcpi->config_vector and not in vpci->vq_vector
>>
>> introduced in:
>> a841f15 kvm tools: Use the new KVM_SIGNAL_MSI ioctl to inject
>> interrupts directly.
>>
>> Signed-off-by: William Dauchy <william@xxxxxxxxx>
>> ---
>>  tools/kvm/virtio/pci.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c
>> index ab1119a..f4ea3c9 100644
>> --- a/tools/kvm/virtio/pci.c
>> +++ b/tools/kvm/virtio/pci.c
>> @@ -288,7 +288,7 @@ int virtio_pci__signal_config(struct kvm *kvm, struct virtio_device *vdev)
>>               }
>>
>>               if (vpci->features & VIRTIO_PCI_F_SIGNAL_MSI)
>> -                     virtio_pci__signal_msi(kvm, vpci, vpci->vq_vector[vpci->config_vector]);
>> +                     virtio_pci__signal_msi(kvm, vpci, vpci->config_vector);
>>               else
>>                       kvm__irq_trigger(kvm, vpci->config_gsi);
>>       } else {
>
> Sasha?

Indeed, we tried signaling the config vector by signaling vq0, woops.

Acked-by: Sasha Levin <levinsasha928@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux