Re: [PATCH 1/5] kvm tools: check ioctl return value for msi signal

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 25, 2012 at 5:15 AM, William Dauchy <william@xxxxxxxxx> wrote:
> On Oct25 10:01, Pekka Enberg wrote:
>> Is this something that happens on your machine? I wonder if it makes more
>> sense to return the error from virtio_pci__signal_vq() and
>> virtio_pci__signal_config() and make the callers deal with it.
>
> no but I thought it was worth not keeping a system call unchecked;
> particularly when you are debugging something (ballooning in my case),
> just wanted to make sure the call was indeed ok.

I wonder if we should revert to using good old IRQ injection in case
this one fails.


Thanks,
Sasha
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux