Re: [PATCH 4/5] kvm tools: initialize msi flags to zero even is not used yet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Oct 2012, William Dauchy wrote:
> kvm explictly checks if msi flags is equal to zero before going
> further; just make sure it is correctly initialized.
> 
> Signed-off-by: William Dauchy <william@xxxxxxxxx>
> ---
>  tools/kvm/virtio/pci.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/kvm/virtio/pci.c b/tools/kvm/virtio/pci.c
> index f4ea3c9..02970fc 100644
> --- a/tools/kvm/virtio/pci.c
> +++ b/tools/kvm/virtio/pci.c
> @@ -243,6 +243,7 @@ static void virtio_pci__signal_msi(struct kvm *kvm, struct virtio_pci *vpci, int
>  		.address_lo = vpci->msix_table[vec].msg.address_lo,
>  		.address_hi = vpci->msix_table[vec].msg.address_hi,
>  		.data = vpci->msix_table[vec].msg.data,
> +		.flags = 0,
>  	};
>  
>  	if (ioctl(kvm->vm_fd, KVM_SIGNAL_MSI, &msi) < 0) {

It is initialized to zero by default as per C struct initialization, isn't 
it? Does this fix a problem you are experiencing?

			Pekka
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux