* Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
> > Looks useful, but please don't waste a full new line on it
> > but embedd it in the already existing status line that
> > prints details like release and version.
>
> Ingo, I thought about doing that but since x86_hyper can be
> NULL (... maybe it should initialized to "Bare-metal" or "No
> Hypervisor"?) I didn't want to break up the printk line. I'll
> look into doing it a different way...
You don't have to break it up - just initialize a name string
to:
const char *machine_name = "x86";
const char *kernel_type = "native";
if (x86_hyperv) {
machine_name = x86_hyperv->name;
kernel_type = "guest";
}
And print it as:
"[%s %s kernel]", machine_name, kernel_type
That way we'll get nice:
... [x86 native kernel]
... [KVM guest kernel]
... [Xen guest kernel]
etc.
Printouts. Please use the naming I outlined above, that's how we
refer to these kernels within arch/x86/.
(The above code is pseudocode, untested.)
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
