On Wed, Oct 17, 2012 at 4:21 PM, Peter Maydell <peter.maydell@xxxxxxxxxx> wrote: > On 14 October 2012 01:04, Christoffer Dall > <c.dall@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> Used to initialize the in-kernel interrupt controller. On ARM we need to >> map the virtual generic interrupt controller (vGIC) into Hyp the guest's >> physicall address space so the guest can access the virtual cpu >> interface. This must be done after the IRQ chips is create and after a >> base address has been provided for the emulated platform (patch is >> following), but before the CPU is initally run. > > I've now written the code for that patch but don't have access to a machine > with the ARM cross compile setup to build it until tomorrow. > >> >> Signed-off-by: Christoffer Dall <c.dall@xxxxxxxxxxxxxxxxxxxxxx> >> --- >> Documentation/virtual/kvm/api.txt | 16 ++++++++++++++++ >> arch/arm/kvm/arm.c | 1 + >> include/linux/kvm.h | 3 +++ >> 3 files changed, 20 insertions(+) >> >> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt >> index 25eacc6..26e953d 100644 >> --- a/Documentation/virtual/kvm/api.txt >> +++ b/Documentation/virtual/kvm/api.txt >> @@ -2102,6 +2102,22 @@ This ioctl returns the guest registers that are supported for the >> KVM_GET_ONE_REG/KVM_SET_ONE_REG calls. >> >> >> +4.79 KVM_INIT_IRQCHIP >> + >> +Capability: KVM_CAP_INIT_IRQCHIP >> +Architectures: arm >> +Type: vm ioctl >> +Parameters: none >> +Returns: 0 on success, -1 on error >> + >> +Initialize the in-kernel interrupt controller. On ARM we need to map the >> +virtual generic interrupt controller (vGIC) into Hyp the guest's physicall > > Should that "Hyp" be deleted? yup > > "physical" > >> +address space so the guest can access the virtual cpu interface. This must be >> +done after the IRQ chips is create and after a base address has been provided > > "chip". "created". > >> +for the emulated platofrm (see KVM_SET_DEVICE_ADDRESS), but before the CPU is >> +initally run. > > "initially". thanks a bunch for those, and sorry about the sloppyness. > > (all these typos are also in your commit message) > yeah, you caught my -ECUTANDPASTE there ;) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
