On (Sun) 30 Sep 2012 [20:05:16], Marcelo Tosatti wrote: > On Thu, Sep 20, 2012 at 09:46:41AM -0300, Marcelo Tosatti wrote: > > On Thu, Sep 20, 2012 at 01:55:20PM +0530, Amit Shah wrote: > > > Commit f349c12c0434e29c79ecde89029320c4002f7253 added the guest stop > > > notification, but it did it in a way that the stop notification would > > > never reach the kernel. The kvm_vm_state_changed() function gets a > > > value of 0 for the 'running' parameter when the VM is stopped, making > > > all the code added previously dead code. > > > > > > This patch reworks the code so that it's called when 'running' is 0, > > > which indicates the VM was stopped. ... > NACK, guest should be notified when the VM is starting, not > when stopping. Ah, right. Amit -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html