On 09/19/2012 07:43 AM, Marcelo Tosatti wrote: >>> - error pfn / mmio pfn / invalid pfn relation >>> >>> Have the meaning of this bits unified in a single function/helper, see >>> comment to patch 1 (perhaps you can further improve). >> >> Sorry, more detail? > > Should force the reader of the code to understand error pfn / mmio pfn / > invalid pfn in a single helper. That is, avoid using error pfn at all. Reasonable suggestion, i will think about it more. Thank you, Marcelo! -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html