Re: [PATCH] KVM: PPC: bookehv: Allow duplicate calls of DO_KVM macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12.09.2012, at 23:38, Scott Wood <scottwood@xxxxxxxxxxxxx> wrote:

> On 09/12/2012 01:56 PM, Alexander Graf wrote:
>> 
>> 
>> On 12.09.2012, at 15:18, Mihai Caraman <mihai.caraman@xxxxxxxxxxxxx> wrote:
>> 
>>> The current form of DO_KVM macro restricts its use to one call per input
>>> parameter set. This is caused by kvmppc_resume_\intno\()_\srr1 symbol
>>> definition.
>>> Duplicate calls of DO_KVM are required by distinct implementations of
>>> exeption handlers which are delegated at runtime.
>> 
>> Not sure I understand what you're trying to achieve here. Please elaborate ;)
> 
> On 64-bit book3e we compile multiple versions of the TLB miss handlers,
> and choose from them at runtime.  

Why?

> Without this patch, we get duplicate
> label errors if more than one variant of the same exception uses DO_KVM.

Makes sense. The proposed solution also looks good. Just quickly walk me through the reasoning for the runtime check again please.


Alex

> 
> -Scott
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe kvm-ppc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux