On 09/10/2012 08:05 PM, Gleb Natapov wrote:
> On Mon, Sep 10, 2012 at 07:17:54PM +0300, Gleb Natapov wrote:
>> > > + return 0;
>> > > +}
>> > > +
>> > > +static inline int kvm_apic_set_id(struct kvm_lapic *apic, u8 id)
>> > > +{
>> > > + apic_set_reg(apic, APIC_ID, id << 24);
>> > > + return recalculate_apic_map(apic->vcpu->kvm);
>> > > +}
>> > > +
>> > > +static inline int kvm_apic_set_ldr(struct kvm_lapic *apic, u32 id)
>> > > +{
>> > > + apic_set_reg(apic, APIC_LDR, id);
>> > > + return recalculate_apic_map(apic->vcpu->kvm);
>> > > +}
>> > > +
>> >
>> > return value of these functions seems never checked.
>> >
>> Yes, the problem is that we can do nothing about the failure if failure
>> happens during guest write.
We can. Return -ENOMEM all the way up to userspace.
>>
> Actually I have an idea how to handle the error. Never return one. If
> map cannot be allocated go slow path always. phys_map should be checked
> for NULL during delivery in this case obviously.
That's better of course (though we have to beware of such tricks, but in
this case the slow path is regularly exercised so it should keep working).
--
error compiling committee.c: too many arguments to function
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
