On 08/29/2012 11:21 AM, Rusty Russell wrote: > >> + /* Coprocessor 0 means we want a core register. */ > >> + if ((u32)reg->id >> KVM_REG_ARM_COPROC_START == 0) > >> + return set_core_reg(vcpu, reg); > > > > ...but if we do go this path, you can't use coprocessor 0 > > to mean core register -- cp0 could be a valid coprocessor > > (the ARM ARM reserves cp0..cp7 for "vendor specific features"). > > Use something outside 0..15. > > OK, changed that too (16). > > And tomorrow they will add 16. Have the first byte say where the state belongs (core or coprocessor) second byte refer to the register family (if applicable), the rest identifies the register within that family. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
