On Wed, Aug 29, 2012 at 10:46:19PM +0200, Sasha Levin wrote: > On 08/29/2012 08:12 PM, Michael S. Tsirkin wrote: > >>> > > What is a good default for net? I guess max sg? > >> > > >> > I think that it depends on the workload. I'd say we should keep the default to 0 > >> > (disabled) unless we can have a good way to adjust it to the load. > > For *all* drivers? > > > > Then it is mostly useless. No one has the time to tweak module > > parameters in real life. > > > > For virtio-net, 16+1 is not too much and ensures we always > > use the cache. > > > > If that works better than 0 I would say run with 17. > > I was being extra-cautious with leaving it disabled until specifically enabled > because I assumed that this would be one of the first comments I'll get if it > was enabled by default :) > > If you're comfortable with setting it to a sane default like 17, I'm perfectly > fine with that as well. > > > Thanks, > Sasha If our testing shows it helps and does not trigger regressions, then why not? module params are mostly there for developers. They are not all that helpful to users. > _______________________________________________ > Virtualization mailing list > Virtualization@xxxxxxxxxxxxxxxxxxxxxxxxxx > https://lists.linuxfoundation.org/mailman/listinfo/virtualization -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
