Re: [Qemu-devel] [PATCHv3 3/4] cpuid: disable pv eoi for 1.1 and older compat types

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 28, 2012 at 05:28:22PM +0000, Blue Swirl wrote:
> On Tue, Aug 28, 2012 at 5:22 PM, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote:
> > On Tue, Aug 28, 2012 at 05:05:25PM +0000, Blue Swirl wrote:
> >> > +static bool _kvm_pv_eoi_disabled;
> >>
> >> NACK. I find your lack of compliance disturbing.
> >
> > Compliance with what? Could you please add some
> > motivation for the NACK?
> 
> You did not respect my review comments.

I merely asking for motivation for the comments.
Anyway, malc explained it to me so I got it now.
Thanks for the review will post soon.

> >
> > --
> > MST
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux