On 2012-08-27 16:53, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 02:48:57PM +0200, Jan Kiszka wrote: >> On 2012-08-27 14:42, Peter Maydell wrote: >>> On 27 August 2012 13:20, Michael S. Tsirkin <mst@xxxxxxxxxx> wrote: >>>> Update linux-headers to version present in Linux 3.6-rc3. >>>> Header asm-x96_64/kvm_para.h update is needed for the new PV EOI >>>> feature. >>>> >>>> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> >>>> --- >>>> linux-headers/asm-s390/kvm.h | 2 +- >>>> linux-headers/asm-s390/kvm_para.h | 2 +- >>>> linux-headers/asm-x86/kvm.h | 1 + >>>> linux-headers/asm-x86/kvm_para.h | 7 +++++++ >>>> linux-headers/linux/kvm.h | 3 +++ >>>> 5 files changed, 13 insertions(+), 2 deletions(-) >>> >>> The latest version of update-linux-headers.sh should have caused >>> this update to include asm-generic/kvm_para.h, I think. Did the >>> script not pull that header in, or were you maybe using an old >>> version of the script or forgot to git add the new file? >> >> To be fair, that is hard to guess. We should add some magic to the >> update script to detect new files and maybe suggest them for addition. >> >> Jan > > But why did you add a header to qemu without adding it > to git? That's a cleaner solution and needs no magic scripting. Yes, this would have been appropriate. Still, a simple "git status -s linux-headers" run at the end of the update script can help reminding people in the future. Jan -- Siemens AG, Corporate Technology, CT RTC ITP SDP-DE Corporate Competence Center Embedded Linux -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
