On Thu, Aug 23, 2012 at 4:12 AM, Min-gyu Kim <mingyu84.kim@xxxxxxxxxxx> wrote: > Dear Christoffer Dall, > Hi Min-gyu (it's not considered best practice to top-post in these types of mailing list, please post inline or bottom-post in the future). > In you code, kvm_alloc_stage2_pgd function allocates page table and memset. > isn't it necessary to clean the data cache after memset? > > For reference, pgd_alloc cleans the area with clean_dcache_area. > You are right, it does. I don't know if the architecture requires it, but we certainly don't want the MMU to see anything else than zeroes at that point. Good catch! > There's some situation that cleaning is not necessary, and clean_dcache_area function becomes empty in that case. > But I think explicit cleaning would be better for portability. > Thanks, -Christoffer -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
