Re: [PATCH 3.6] KVM: x86 emulator: use stack size attribute to mask rsp in stack ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 19, 2012 at 02:34:31PM +0300, Avi Kivity wrote:
> The sub-register used to access the stack (sp, esp, or rsp) is not
> determined by the address size attribute like other memory references,
> but by the stack segment's B bit (if not in x86_64 mode).
> 
> Fix by using the existing stack_mask() to figure out the correct mask.
> 
> This long-existing bug was exposed by a combination of a27685c33acccce
> (emulate invalid guest state by default), which causes many more
> instructions to be emulated, and a seabios change (possibly a bug) which
> causes the high 16 bits of esp to become polluted across calls to real
> mode software interrupts.
> 
> Signed-off-by: Avi Kivity <avi@xxxxxxxxxx>

Applied, thanks.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux