On Tue, 14 Aug 2012, Cornelia Huck wrote: > Sebastian Ott <sebott@xxxxxxxxxxxxxxxxxx> wrote: > > On Tue, 7 Aug 2012, Cornelia Huck wrote: > > > +/** > > > + * ccw_device_get_schid - obtain a subchannel id > > > + * @cdev: device to obtain the id for > > > + * @schid: where to fill in the values > > > + */ > > > +void ccw_device_get_schid(struct ccw_device *cdev, struct subchannel_id *schid) > > > +{ > > > + *schid = cdev->private->schid; > > > +} > > > +EXPORT_SYMBOL(ccw_device_get_schid); > > > > After I gave this some thought I like your version of this function > > better. But please use the id of the parent subchannel instead of the > > copy in cdev->private (since this will be removed soon). I'll do a > > cleanup patch to convert the internal users of the old function to use > > the one above. > > Good, will change that (I think we can rely on a ccw device always > having either a real subchannel or the orphanage pseudo subchannel as > parent). Yes you can rely on that. > > Small taste question: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL? get_subchannel_id was EXPORT_SYMBOL_GPL since its going to replace this let's use the _GPL variant. Regards, Sebastian -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html