--- Asias He <asias.hejun@xxxxxxxxx> schrieb am Di, 14.8.2012: > Paul, > > On Tue, Aug 14, 2012 at 1:11 AM, Paul Neumann <paul104x@xxxxxxxx> > wrote: > > The errors from kvm_cmd_run_init() are not handled > properly as they are > > returned as positive values. > > > > Signed-off-by: Paul Neumann <paul104x@xxxxxxxx> > > Looks good to me. Paul, can you tell how the segfault > is triggered as > well? Thanks. > The segfault is triggered by just running "lkvm run". On my system, it does not find any kernel, so kvm_cmd_run_init() returns EINVAL which fails the (r < 0) check in kvm_cmd_run(). Since kvm_cmd_run_init() does not get to initialize the cpus, kvm_cpus gets mistakenly dereferenced in kvm_cmd_run_work(). Paul > > -- > Asias He > -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
