On 08/11/2012 08:07 AM, Tabi Timur-B04825 wrote: > On Sat, Aug 11, 2012 at 2:01 AM, Geert Uytterhoeven > <geert@xxxxxxxxxxxxxx> wrote: >> On Sat, Aug 11, 2012 at 12:21 AM, Scott Wood <scottwood@xxxxxxxxxxxxx> wrote: >>> +EXPORT_SYMBOL(epapr_hypercall_start); >> >> EXPORT_SYMBOL_GPL? > > We prefer EXPORT_SYMBOL. We don't want to restrict our customers from > having to use GPL code. > More specifically in this case, I don't see how use of this symbol in any way suggests that the code would be GPL-derivative. The API is documented in the ePAPR standard or other external sources -- not a kernel internal implementation issue. The contents of epapr_hypercall_start itself are not copyrightable (by default it's basically "return -1", and is patched at runtime with a few instructions provided by the hypervisor). The header file with the inline accessors is dual licensed (and also unlikely to be copyrightable, in terms of what actually makes it into the output binary). -Scott -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html