On Tue, 7 Aug 2012 16:52:47 +0200, Cornelia Huck <cornelia.huck@xxxxxxxxxx> wrote:
> Add a driver for kvm guests that matches virtual ccw devices provided
> by the host as virtio bridge devices.
Hi Cornelia,
OK, this is a good opportunity to fix some limitations, just as
we did for virtio_mmio (drivers/virtio/virtio_mmio.c).
1) Please don't limit yourself to 32 feature bits! If you look at how
virtio_mmio does it, they use a selector to index into a
theoretically-infinite array of feature bits:
* 0x010 R HostFeatures Features supported by the host
* 0x014 W HostFeaturesSel Set of host features to access via HostFeatures
*
* 0x020 W GuestFeatures Features activated by the guest
* 0x024 W GuestFeaturesSel Set of activated features to set via GuestFeatures
2) Please also allow the guest to set the alignment for virtio ring
layout (it controls the spacing between the rings), eg:
* 0x03c W QueueAlign Used Ring alignment for the current queue
3) Finally, make sure the guest can set the size of the queue, in case
it can't allocate the size the host suggests, eg:
* 0x034 R QueueNumMax Maximum size of the currently selected queue
* 0x038 W QueueNum Queue size for the currently selected queue
This means the host can suggest huge queues, knowing the guest won't
simply fail if it does so.
Note that we're also speculating a move to a new vring format, which
will probably be little-endian. But you probably want a completely new
ccw code for that anyway.
Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
