Re: [PATCH 1/2] kvm tools: Fix formatting of error message in TAP handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 10, 2012 at 1:38 PM, Michael Ellerman
<michael@xxxxxxxxxxxxxx> wrote:
> This error message is missing a space, and has a redundant ":" at the end,
> currently it produces:
>
>   You have requested a TAP device, but creation of one hasfailed because:: No such file or directory
>
> Add a space to "hasfailed" and remove the extra ":".
>
> Don't split the line to improve grepability.
>
> Signed-off-by: Michael Ellerman <michael@xxxxxxxxxxxxxx>
> ---
>  tools/kvm/virtio/net.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/tools/kvm/virtio/net.c b/tools/kvm/virtio/net.c
> index 10420ae..8f3735b 100644
> --- a/tools/kvm/virtio/net.c
> +++ b/tools/kvm/virtio/net.c
> @@ -526,8 +526,7 @@ void virtio_net__init(const struct virtio_net_params *params)
>         ndev->mode = params->mode;
>         if (ndev->mode == NET_MODE_TAP) {
>                 if (!virtio_net__tap_init(params, ndev))
> -                       die_perror("You have requested a TAP device, but creation of one has"
> -                                       "failed because:");
> +                       die_perror("You have requested a TAP device, but creation of one has failed because");
>                 ndev->ops = &tap_ops;
>         } else {
>                 ndev->info.host_ip              = ntohl(inet_addr(params->host_ip));
> --
> 1.7.9.5


Acked-by: Asias He <asias.hejun@xxxxxxxxx>

-- 
Asias He
--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [KVM ARM]     [KVM ia64]     [KVM ppc]     [Virtualization Tools]     [Spice Development]     [Libvirt]     [Libvirt Users]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite Questions]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux