Il 09/08/2012 09:28, liu ping fan ha scritto: >>> >> +static void >>> >> +pci_e1000_unmap(PCIDevice *p) >>> >> +{ >>> >> + /* DO NOT FREE anything!until refcnt=0 */ >>> >> + /* isolate from memory view */ >>> >> +} >> > >> > At least you need to call the superclass method. >> > > Refer to 0013-hotplug-introduce-qdev_unplug_complete-to-remove-dev.patch, > we have the following sequence > qdev_unmap->pci_unmap_device->pci_e1000_unmap. So pci_e1000_unmap > need not to do anything. But then this patch is unnecessary, isn't it? Paolo -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html